Add infinite sub task nesting #61

2025-05-25T11:19:26Z

edfloreshz commented

2025-05-25 11:19:26 +00:00

(Migrated from github.com)

This pull request introduces several updates across the codebase, focusing on refactoring, feature enhancements, and UI/UX improvements.

Added infinite sub task nesting to the tasks list.
Task list now aligns to the left when context drawer is open to improve readability.
Replaced content::Task and details::Task enums with content::Output and details::Output enums to improve naming clarity and better reflect their purpose.
Added recursive sub-task formatting in Markdown for better handling of nested sub-tasks, ensuring proper indentation and readability.
Introduced new modules for styling, including segmented_control, text_editor, and text_input.
Adjusted the default application window size to 850x700.
Added a new icon view-more-symbolic and adjusted the size of flag-related icons for consistency in the UI.
Added a new localization string add-notes to support additional task-related functionality in the UI.
Updated the path for libcosmic in Cargo.toml to point to a new external directory, improving project structure.

Gets us even closer to #34

This pull request introduces several updates across the codebase, focusing on refactoring, feature enhancements, and UI/UX improvements. * Added infinite sub task nesting to the tasks list. * Task list now aligns to the left when context drawer is open to improve readability. * Replaced `content::Task` and `details::Task` enums with `content::Output` and `details::Output` enums to improve naming clarity and better reflect their purpose. * Added recursive sub-task formatting in Markdown for better handling of nested sub-tasks, ensuring proper indentation and readability. * Introduced new modules for styling, including `segmented_control`, `text_editor`, and `text_input`. * Adjusted the default application window size to `850x700`. * Added a new icon `view-more-symbolic` and adjusted the size of flag-related icons for consistency in the UI. * Added a new localization string `add-notes` to support additional task-related functionality in the UI. * Updated the path for `libcosmic` in `Cargo.toml` to point to a new external directory, improving project structure. ![image](https://github.com/user-attachments/assets/15d6811a-ebb9-44b5-9d93-7fe3096e1bf7) ![image](https://github.com/user-attachments/assets/75b4fc08-ce8c-42aa-891b-4a9afdccc363) Gets us even closer to #34

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2025-05-25 11:20:10 +00:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull Request Overview

This pull request introduces infinite sub-task nesting and several refactorings across the codebase to improve naming clarity, UI consistency, and overall maintainability. Key changes include replacing old sub-task message handling in Details with a new Output enum, updating storage APIs to use concrete List objects and file paths, and adding new styling and localization updates.

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/details.rs	Refactored Details to use non-optional task field; updated message variants and UI behavior.
src/core/storage.rs	Updated API signatures to use List objects and file paths with refined task and list handling.
src/core/models/task.rs & list.rs	Introduced file path management in Task and List creation for improved persistence.
src/app/style/*	Added new style modules for segmented control, text editor, and text input.
src/app/markdown.rs	Implemented recursive formatting for nested sub-tasks in Markdown output.
src/app/icons.rs & src/app.rs	Updated icon sizes and integrated new message variants and storage usage throughout the app.
i18n/en/tasks.ftl & Cargo.toml	Added new localization string and updated the libcosmic path, respectively.

## Pull Request Overview This pull request introduces infinite sub-task nesting and several refactorings across the codebase to improve naming clarity, UI consistency, and overall maintainability. Key changes include replacing old sub-task message handling in Details with a new Output enum, updating storage APIs to use concrete List objects and file paths, and adding new styling and localization updates. ### Reviewed Changes Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment. <details> <summary>Show a summary per file</summary> | File | Description | |-----------------------------------|--------------------------------------------------------------------------------------------| | src/details.rs | Refactored Details to use non-optional task field; updated message variants and UI behavior. | | src/core/storage.rs | Updated API signatures to use List objects and file paths with refined task and list handling.| | src/core/models/task.rs & list.rs | Introduced file path management in Task and List creation for improved persistence. | | src/app/style/* | Added new style modules for segmented control, text editor, and text input. | | src/app/markdown.rs | Implemented recursive formatting for nested sub-tasks in Markdown output. | | src/app/icons.rs & src/app.rs | Updated icon sizes and integrated new message variants and storage usage throughout the app. | | i18n/en/tasks.ftl & Cargo.toml | Added new localization string and updated the libcosmic path, respectively. | </details>

src/details.rs

					
				@ -303,1 +181,4 @@

				            spacing.space_s,

				            spacing.space_none,

				            spacing.space_s,

				        ])

In the Message::AddTask branch, 'priority' is not defined in this scope. It appears that the sub-task addition logic was removed but 'priority' is still referenced. Consider reviewing and updating this branch to either remove the assignment or correctly handle sub-task creation.

Sign in to join this conversation.

No reviewers